Skip to main content

Rails: Forcing a Controller to have a Comment

I'm using acl_system2 for authorization. As a general rule, I think apps should deny access to everything, and then open up permissions where appropriate. However, acl_system2 makes it hard to restrict permissions in ApplicationController and open them up in each subclass.

That means I have to remember to control access in each controller. acl_system2 will allow access unless you tell it not to. That could lead to accidents. Hence, I started with the following in ApplicationController:
# === Access controls
# Each controller is responsible for enforcing access controls properly. It
# should either have some variation of::
# before_filter :require_user
# access_control :DEFAULT => 'admin'
# Or at the very least::
# # No access control is required:
# # before_filter :require_user
# # access_control :DEFAULT => 'admin'
# See for more details.
Of course, that's just a comment which no one will ever read anyway. Hence, I wrote a RSpec test to enforce it:
context "Controllers" do
controllers = Dir[File.expand_path(File.dirname(__FILE__) + "/../app/controllers/*.rb")]
it "should not be empty" do
controllers.should_not be_empty
controllers.each do |f|
contents =

context f do
it %{should contain "before_filter :require_user" at least in a comment (see application_controller.rb)} do
contents.should =~ /before_filter :require_user/
it %{should contain "access_control :DEFAULT => 'admin'" at least in a comment (see application_controller.rb)} do
contents.should =~ /access_control :DEFAULT => 'admin'/
Conceptually, what's going on is that I have an interface that I want child classes to follow. Part of that interface is that you must at least provide a comment about why you don't have to require access control. Funky!


Popular posts from this blog

Drawing Sierpinski's Triangle in Minecraft Using Python

In his keynote at PyCon, Eben Upton, the Executive Director of the Rasberry Pi Foundation, mentioned that not only has Minecraft been ported to the Rasberry Pi, but you can even control it with Python. Since four of my kids are avid Minecraft fans, I figured this might be a good time to teach them to program using Python. So I started yesterday with the goal of programming something cool for Minecraft and then showing it off at the San Francisco Python Meetup in the evening.

The first problem that I faced was that I didn't have a Rasberry Pi. You can't hack Minecraft by just installing the Minecraft client. Speaking of which, I didn't have the Minecraft client installed either ;) My kids always play it on their Nexus 7s. I found an open source Minecraft server called Bukkit that "provides the means to extend the popular Minecraft multiplayer server." Then I found a plugin called RaspberryJuice that implements a subset of the Minecraft Pi modding API for Bukkit s…

Apple: iPad and Emacs

Someone asked my boss's buddy Art Medlar if he was going to buy an iPad. He said, "I figure as soon as it runs Emacs, that will be the sign to buy." I think he was just trying to be funny, but his statement is actually fairly profound.

It's well known that submitting iPhone and iPad applications for sale on Apple's store is a huge pain--even if they're free and open source. Apple is acting as a gatekeeper for what is and isn't allowed on your device. I heard that Apple would never allow a scripting language to be installed on your iPad because it would allow end users to run code that they hadn't verified. (I don't have a reference for this, but if you do, please post it below.) Emacs is mostly written in Emacs Lisp. Per Apple's policy, I don't think it'll ever be possible to run Emacs on the iPad.

Emacs was written by Richard Stallman, and it practically defines the Free Software movement (in a manner of speaking at least). Stal…

ERNOS: Erlang Networked Operating System

I've been reading Dreaming in Code lately, and I really like it. If you're not a dreamer, you may safely skip the rest of this post ;)

In Chapter 10, "Engineers and Artists", Alan Kay, John Backus, and Jaron Lanier really got me thinking. I've also been thinking a lot about Minix 3, Erlang, and the original Lisp machine. The ideas are beginning to synthesize into something cohesive--more than just the sum of their parts.

Now, I'm sure that many of these ideas have already been envisioned within, LLVM, Microsoft's Singularity project, or in some other place that I haven't managed to discover or fully read, but I'm going to blog them anyway.

Rather than wax philosophical, let me just dump out some ideas:Start with Minix 3. It's a new microkernel, and it's meant for real use, unlike the original Minix. "This new OS is extremely small, with the part that runs in kernel mode under 4000 lines of executable code." I bet it&…