Skip to main content

Software Engineering: Facebook Thrift

I read Facebook's Thrift Whitepaper. Thrift is, basically, Facebook's open source replacement for CORBA. In short, it looks fine.

The whitepaper mentions CORBA only very briefly: "Relatively comprehensive, debatably overdesigned and heavyweight. Comparably cumbersome software installation."

Thrift feels very C++-ish. For instance, they use Boost. The Thrift IDL compiler is written in C++ with Lex and Yacc. They also implemented their own C++ thread primatives, including Mutex, Condition, and Monitor. The whitepaper also discusses their threading and memory management issues in C++.

They have an interesting scheme for versioning APIs such as struct fields and function parameters. They put numbers on the fields so that if a client and server aren't currently running the same version of the IDL, things can continue working. This is important for rolling upgrades. Here's an example:
struct Example { 
1:i32 number=10,
2:i64 bigNumber,
3:double decimals,
4:string name="thrifty"
}
That was, perhaps, the most surprising thing to me. I was having BASIC flashbacks. I assume that if you need to delete a field, you just delete the whole line and leave a gap in the numbers.

However, an interesting case arises. What happens if you delete field 4 in the above example, and someone else unknowingly adds a new field, reusing the same id? It's probably important to leave a comment in the code saying which is the highest id that has been used so far.

I don't think I would have used numbers. Instead, I would have used a "deleted" keyword. Of course, numbers could still be used in the implementation, behind the scenes:
struct Example { 
i32 number=10,
deleted i64 bigNumber,
double decimals,
deleted string name="thrifty"
}
Perhaps they thought of this too, but there's some reason they dismissed it. For instance, it is sort of ugly to have those "deleted" lines, and you can only add new fields at the end. Heh, I guess this is one time where numbers actually enhance readability ;)

Anyway, I didn't actually try it out, but I'm sure it's fine.

Comments

Leon Atkinson said…
It's cool that Facebook is throwing off a bunch of open source. Did you see Facebook's Cassandra? It's something like BigTable.
Take at peek at Google's Protocol Buffers to see what Facebook based their design off of.

From what I've read Facebook was hiring Google engineers with Protocol Buffers experience when they were building Thrift.
jjinux said…
> It's cool that Facebook is throwing off a bunch of open source. Did you see Facebook's Cassandra? It's something like BigTable.

Awesome!

> Take at peek at Google's Protocol Buffers to see what Facebook based their design off of.

Oh, interesting!
Anonymous said…
jeez, not sure where this meme started, but thrift was based on pillar, a cross-language rpc framework from our former cto, written in ml. for all we know, google based protocol buffers on pillar.
jjinux said…
> jeez, not sure where this meme started

CORBA? What was popular before CORBA?

By the way, +1 for mentioning ML ;)

Popular posts from this blog

Drawing Sierpinski's Triangle in Minecraft Using Python

In his keynote at PyCon, Eben Upton, the Executive Director of the Rasberry Pi Foundation, mentioned that not only has Minecraft been ported to the Rasberry Pi, but you can even control it with Python . Since four of my kids are avid Minecraft fans, I figured this might be a good time to teach them to program using Python. So I started yesterday with the goal of programming something cool for Minecraft and then showing it off at the San Francisco Python Meetup in the evening. The first problem that I faced was that I didn't have a Rasberry Pi. You can't hack Minecraft by just installing the Minecraft client. Speaking of which, I didn't have the Minecraft client installed either ;) My kids always play it on their Nexus 7s. I found an open source Minecraft server called Bukkit that "provides the means to extend the popular Minecraft multiplayer server." Then I found a plugin called RaspberryJuice that implements a subset of the Minecraft Pi modding API for B

Ubuntu 20.04 on a 2015 15" MacBook Pro

I decided to give Ubuntu 20.04 a try on my 2015 15" MacBook Pro. I didn't actually install it; I just live booted from a USB thumb drive which was enough to try out everything I wanted. In summary, it's not perfect, and issues with my camera would prevent me from switching, but given the right hardware, I think it's a really viable option. The first thing I wanted to try was what would happen if I plugged in a non-HiDPI screen given that my laptop has a HiDPI screen. Without sub-pixel scaling, whatever scale rate I picked for one screen would apply to the other. However, once I turned on sub-pixel scaling, I was able to pick different scale rates for the internal and external displays. That looked ok. I tried plugging in and unplugging multiple times, and it didn't crash. I doubt it'd work with my Thunderbolt display at work, but it worked fine for my HDMI displays at home. I even plugged it into my TV, and it stuck to the 100% scaling I picked for the othe

Creating Windows 10 Boot Media for a Lenovo Thinkpad T410 Using Only a Mac and a Linux Machine

TL;DR: Giovanni and I struggled trying to get Windows 10 installed on the Lenovo Thinkpad T410. We struggled a lot trying to create the installation media because we only had a Mac and a Linux machine to work with. Everytime we tried to boot the USB thumb drive, it just showed us a blinking cursor. At the end, we finally realized that Windows 10 wasn't supported on this laptop :-/ I've heard that it took Thomas Edison 100 tries to figure out the right material to use as a lightbulb filament. Well, I'm no Thomas Edison, but I thought it might be noteworthy to document our attempts at getting it to boot off a USB thumb drive: Download the ISO. Attempt 1: Use Etcher. Etcher says it doesn't work for Windows. Attempt 2: Use Boot Camp Assistant. It doesn't have that feature anymore. Attempt 3: Use Disk Utility on a Mac. Erase a USB thumb drive: Format: ExFAT Scheme: GUID Partition Map Mount the ISO. Copy everything from